GH-1285 Change log level to debug for failed function lookup #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-cloud#1285 Signed-off-by: Wilson da Rocha Franca <wilsonrf@gmail.com>
Contributor
|
I agree with your assertion, so will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1285
Related #1265
The warn log was introduced in the latest release for a failed function lookup.
If I understood correctly, this is being emitted on every first call to the function when the first lookup happens, which can significantly pollute the logs in production environments.
Since this message seems not to indicate an error or unexpected behaviour, but rather reflects a normal and expected code path, debug can be a more appropriate log level.
This is my first contribution to the project - please feel free to disregard if you believe this change is not aligned with the logging strategy.